wuchong commented on a change in pull request #13834:
URL: https://github.com/apache/flink/pull/13834#discussion_r521343815
##########
File path:
flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDataSerDeSchemaTest.java
##########
@@ -150,6 +151,24 @@ public void testSerializeDeserializeCustomizedProperties()
throws Exception {
deserConfig,
";");
testField(STRING(), "null", "null", serConfig, deserConfig,
";"); // string because null literal has not been set
+ testField(TIME(3), "12:12:12.232",
LocalTime.parse("12:12:12.232") , deserConfig , ";");
+ testField(TIME(3), "12:12:12.232342",
LocalTime.parse("12:12:12.232") , deserConfig , ";");
+ testField(TIME(3), "12:12:12.23",
LocalTime.parse("12:12:12.23") , deserConfig , ";");
+ testField(TIME(2), "12:12:12.23",
LocalTime.parse("12:12:12.23") , deserConfig , ";");
+ testField(TIME(2), "12:12:12.232312",
LocalTime.parse("12:12:12.23") , deserConfig , ";");
+ testField(TIME(2), "12:12:12.2", LocalTime.parse("12:12:12.2")
, deserConfig , ";");
+ testField(TIME(1), "12:12:12.2", LocalTime.parse("12:12:12.2")
, deserConfig , ";");
+ testField(TIME(1), "12:12:12.2235",
LocalTime.parse("12:12:12.2") , deserConfig , ";");
+ testField(TIME(1), "12:12:12", LocalTime.parse("12:12:12") ,
deserConfig , ";");
+ testField(TIME(0), "12:12:12", LocalTime.parse("12:12:12") ,
deserConfig , ";");
+ testField(TIME(0), "12:12:12.45", LocalTime.parse("12:12:12") ,
deserConfig , ";");
Review comment:
We only use `testNullableField` to test conversion without precision
loss.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
