dannycranmer commented on a change in pull request #14049:
URL: https://github.com/apache/flink/pull/14049#discussion_r523099583
##########
File path: flink-end-to-end-tests/test-scripts/test_sql_client.sh
##########
@@ -61,15 +61,27 @@ for SQL_JAR in $SQL_JARS_DIR/*.jar; do
! [[ $EXTRACTED_FILE = "$EXTRACTED_JAR/META-INF"* ]] && \
! [[ $EXTRACTED_FILE = "$EXTRACTED_JAR/LICENSE"* ]] && \
! [[ $EXTRACTED_FILE = "$EXTRACTED_JAR/NOTICE"* ]] && \
- ! [[ $EXTRACTED_FILE = "$EXTRACTED_JAR/org/apache/avro"* ]] ; then
+ ! [[ $EXTRACTED_FILE = "$EXTRACTED_JAR/org/apache/avro"* ]] && \
+ # Following required by amazon-kinesis-producer in
flink-connector-kinesis
+ ! [[ $EXTRACTED_FILE =
"$EXTRACTED_JAR/amazon-kinesis-producer-native-binaries"* ]] && \
+ ! [[ $EXTRACTED_FILE = "$EXTRACTED_JAR/cacerts"* ]] ; then
echo "Bad file in JAR: $EXTRACTED_FILE"
exit 1
fi
done
- # check for proper factory
- if [ ! -f
$EXTRACTED_JAR/META-INF/services/org.apache.flink.table.factories.TableFactory
]; then
- echo "No table factory found in JAR: $SQL_JAR"
+ # check for proper legacy table factory
+ # Kinesis connector does not support legacy Table API
+ if [[ $SQL_JAR == *"flink-sql-connector-kinesis"* ]]; then
+ echo "Skipping Legacy Table API for: $SQL_JAR"
+ elif [ ! -f
$EXTRACTED_JAR/META-INF/services/org.apache.flink.table.factories.TableFactory
]; then
+ echo "No legacy table factory found in JAR: $SQL_JAR"
+ exit 1
+ fi
+
+ # check for new legacy table factory
Review comment:
Done. Good spot, "new legacy" is a bit of an oxymoron :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
