kl0u commented on a change in pull request #14061:
URL: https://github.com/apache/flink/pull/14061#discussion_r523956778
##########
File path: docs/dev/connectors/streamfile_sink.md
##########
@@ -765,6 +765,7 @@ and Flink will throw an exception.
normal job termination (*e.g.* finite input stream) and termination due to
failure, upon normal termination of a job, the last
in-progress files will not be transitioned to the "finished" state.
+TODO I think this is wrong.
Review comment:
For example
[here](https://github.com/apache/flink/blob/master/flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableFsDataOutputStream.java#L299)
we do not seem to fail. Although S3 fails
(https://github.com/apache/flink/blob/master/flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/writer/S3Committer.java#L100),
so the comment is correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
