kl0u commented on a change in pull request #14061:
URL: https://github.com/apache/flink/pull/14061#discussion_r524201163
##########
File path: docs/dev/connectors/streamfile_sink.md
##########
@@ -765,6 +765,7 @@ and Flink will throw an exception.
normal job termination (*e.g.* finite input stream) and termination due to
failure, upon normal termination of a job, the last
in-progress files will not be transitioned to the "finished" state.
+TODO I think this is wrong.
Review comment:
Yes, I think we should definitely make the behaviour uniform. This is a
bug and we should open a JIRA for that and this is why I put the comment, so
that the reviewers can also have a look and verify. But for the docs, I think
we should simply have the "least common denominator" which is hard failure in
this case. Feel free to open an issue for this and potentially point to the
discussion in this PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
