AHeise commented on a change in pull request #14052:
URL: https://github.com/apache/flink/pull/14052#discussion_r525866375
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
##########
@@ -1125,70 +1127,137 @@ public void testUnblockReleasedChannel() throws
Exception {
@Test
public void testPrioritySequenceNumbers() throws Exception {
- final NetworkBufferPool networkBufferPool = new
NetworkBufferPool(4, 4096);
- SingleInputGate inputGate = new SingleInputGateBuilder()
-
.setChannelFactory(InputChannelBuilder::buildRemoteChannel)
-
.setBufferPoolFactory(networkBufferPool.createBufferPool(1, 4))
- .setSegmentProvider(networkBufferPool)
- .build();
- final RemoteInputChannel channel = (RemoteInputChannel)
inputGate.getChannel(0);
- inputGate.setup();
- inputGate.requestPartitions();
+ final RemoteInputChannel channel =
buildInputGateAndGetChannel();
+ sendBuffersAndBarrier(channel, 0);
Review comment:
I'd like to see them inlined. I aim to always have a test structured in
the _given_, _when_, _then_ structure and I think with this change, you managed
to get exactly that (much better than it was before).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
