AHeise commented on a change in pull request #14052:
URL: https://github.com/apache/flink/pull/14052#discussion_r525867148
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -98,14 +100,11 @@
private final BufferManager bufferManager;
- /**
- * Indicates the last overtaken sequence number by the most recent
{@link CheckpointBarrier}
- * before task thread started checkpoint, or {@code null} if {@link
CheckpointBarrier} hasn't
- * arrived yet.
- */
@GuardedBy("receivedBuffers")
- @Nullable
- private Integer lastOvertakenSequenceNumber = null;
+ private int lastBarrierSequenceNumber = NONE;
Review comment:
As a reviewer of this PR, I'm more confused by separation. I think Piotr
is also not a big fan of touching the same code in multiple commits. The
question is which confusion you want to avoid? Is it about code ownership?
Then, I wouldn't mind keeping it separate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
