John-J-Mathews commented on a change in pull request #14144:
URL: https://github.com/apache/flink/pull/14144#discussion_r527209632
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
##########
@@ -145,6 +145,12 @@
private static final long serialVersionUID = 1L;
+ /**
+ * Number of characters to truncate the taskName to for the Kafka
transactionalId.
+ * The maximum this can possibly be set to is 32,767 - (length of
operatorUniqueId).
+ */
+ private static final short maxTaskNameSize = 10_000;
Review comment:
Wasn't sure what to go with as a value here but using the max characters
seems unnecessarily expensive and probably doesn't provide a ton of signal.
If others agree, I thinking moving to something even lower may even be
better than 10k given I believe the transactionId is sent over the network to
the broker which is a lot of wasted network overhead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
