becketqin commented on pull request #14104: URL: https://github.com/apache/flink/pull/14104#issuecomment-731783464
@StephanEwen It seems the behaviors are slightly different. 1. This patch has different behaviors for fatal and non-fatal throwables. The former crashes the JVM and the latter fails the job, while #14030 only fails the job. 2. Sometimes the UncaughtExceptionHandler does not always work when the thread is put into the `ExcecutorService`, I think the runnable passed to the thread factory depends on the call it made. In case of `ExecutorService.submit()` the runnable would be a `FutureTask` which already catches all the throwables without invoking `UncaughtExceptionHandler`. So the `UncaughtExceptionHandler` might be a little fragile when working with executors. It looks that this patch still improves the error handling a little bit. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
