StephanEwen commented on a change in pull request #14104:
URL: https://github.com/apache/flink/pull/14104#discussion_r528210858
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java
##########
@@ -107,7 +107,14 @@ public void start() throws Exception {
// The start sequence is the first task in the coordinator
executor.
// We rely on the single-threaded coordinator executor to
guarantee
// the other methods are invoked after the enumerator has
started.
- coordinatorExecutor.execute(() -> enumerator.start());
+ coordinatorExecutor.execute(() -> {
+ try {
+ enumerator.start();
+ } catch (Exception e) {
Review comment:
Can we change this to `Throwable`? Then we also catch issues with
dependencies, classpaths. It is what all other parts of Flink do and it is
important. Otherwise one job with wrong dependencies kills a shared cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
