kl0u commented on a change in pull request #14157:
URL: https://github.com/apache/flink/pull/14157#discussion_r528592226
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
##########
@@ -371,6 +372,18 @@ public static void
printHelpForRun(Collection<CustomCommandLine> customCommandLi
System.out.println();
}
+ public static void printHelpForRunApplication() {
+ HelpFormatter formatter = new HelpFormatter();
+ formatter.setLeftPadding(5);
+ formatter.setWidth(80);
+
+ System.out.println("\nAction \"run-application\" runs an
application in Application Mode.");
+ System.out.println("\n Syntax: run-application -t
[kubernetes-application, yarn-application] [OPTIONS] <jar-file> <arguments>");
Review comment:
For the `run-application` I agree, and this would be my answer actually
if you suggested to use the `run` for everything :)
I agree also about the extensibility for the general help message of the
`-t`. I may need to think though how to add it. For the `run-application`
though, we should still hardcode it because we want to say that the user can
only use a subset of the available executors with this command. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
