StephanEwen commented on a change in pull request #14186:
URL: https://github.com/apache/flink/pull/14186#discussion_r529488101
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinator.java
##########
@@ -137,7 +145,7 @@ default void notifyCheckpointAborted(long checkpointId) {}
* complete (for example when a system failure happened directly after
committing the checkpoint,
* before calling the {@link #notifyCheckpointComplete(long)} method).
*/
- void resetToCheckpoint(byte[] checkpointData) throws Exception;
+ void resetToCheckpoint(@Nullable byte[] checkpointData) throws
Exception;
Review comment:
For a public API, I would go with two methods. For this internal API, I
would not change it at this point.
For the public API of the source, we translate the restore anyways to a
re-instantiation.
- Restore with null state becomes `source.createEnumerator()`
- Restore with proper state becomes `source.restoreEnumerator()`.
So for users, this confusion should not exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
