tillrohrmann commented on a change in pull request #14186:
URL: https://github.com/apache/flink/pull/14186#discussion_r530411573
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1304,12 +1312,34 @@ public boolean restoreLatestCheckpointedStateToAll(
final Set<ExecutionJobVertex> tasks,
final boolean allowNonRestoredState) throws Exception {
- return restoreLatestCheckpointedStateInternal(tasks, true,
false, allowNonRestoredState);
+ return restoreLatestCheckpointedStateInternal(
+ tasks,
+ CoordinatorRestore.ALWAYS, // global recovery
restores coordinators, or resets them to empty
+ false, // recovery might come before first
successful checkpoint
+ allowNonRestoredState);
+ }
+
+ /**
+ * Restores the latest checkpointed at the beginning of the job
execution.
+ * If there is a checkpoint, this method acts like a "global
restore"-style
+ * operation where all stateful tasks and coordinators from the given
+ * set of Job Vertices are restored.
+ *
+ * @param tasks Set of job vertices to restore. State for these
vertices is
+ * restored via {@link
Execution#setInitialState(JobManagerTaskRestore)}.
+ * @return True, if a checkpoint was found and its state was restored,
false otherwise.
+ */
+ public boolean restoreInitialCheckpointIfPresent(final
Set<ExecutionJobVertex> tasks) throws Exception {
+ return restoreLatestCheckpointedStateInternal(
+ tasks,
+ CoordinatorRestore.ONLY_FOR_EXISTING_CHECKPOINT,
Review comment:
Ok this makes sense. Maybe we can document it somewhere that this is an
optimization and not required from a correctness point of view. Thanks for the
explanation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
