StephanEwen edited a comment on pull request #14199: URL: https://github.com/apache/flink/pull/14199#issuecomment-733659726
Thanks, @azagrebin this looks good to me. The setup logic does look a bit complex - I am wondering if it makes sense to have more of the setup logic in the MiniCluster itself? To avoid that future changes to the HAServices need to touch this test class. (The philosophy being that this class tests DataStream and File Source, so changes not relating to those should ideally not require to touch that class). What do you think about adding also a failover case also for the batch execution? Then we would have everything covered. We could then rename this test from `FileTextLinesITCase` to a `FileSourceFailoverITCase`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
