[ 
https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190942#comment-15190942
 ] 

ASF GitHub Bot commented on FLINK-3544:
---------------------------------------

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1741#issuecomment-195374162
  
    Overall, the change looks good. I'm happy to see that the YARN tests 
haven't been touched much. As long as these tests are present, most of the 
features users need should work properly.
    Also my tests on a secured virtual machine were successful.
    
    I don't have the time to check in detail if all the message sequences and 
different procedures are implemented correctly but given that everything worked 
when I tested it, I'm positive that we can merge the change soon.
    
    I think a quick review by @StephanEwen and @tillrohrmann would be good.


> ResourceManager runtime components
> ----------------------------------
>
>                 Key: FLINK-3544
>                 URL: https://issues.apache.org/jira/browse/FLINK-3544
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ResourceManager
>    Affects Versions: 1.1.0
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>             Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to