StephanEwen commented on pull request #13885: URL: https://github.com/apache/flink/pull/13885#issuecomment-737999505
The PR looks to copy code from the Java SDK, which is Oracle licensed proprietary code, so this cannot be merged in any way. @AHeise I think that is the reason for the unexpected formatting / visibility. The PR also introduces again double wrapping: Hadoop's Stream -> `HadoopDataInputStream` -> `FSDataBufferedInputStream` I would suggest to close this PR and go back to first defining what actually needs to be done, and how to approach this (not by copying copyrighted code!). Writing code here is the least important thing (introducing a buffer is not a complex problem) and it looks the PR takes a lot of iterations because it is always putting code in place before understanding how the problem should be approached. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
