alpinegizmo commented on pull request #14292:
URL: https://github.com/apache/flink/pull/14292#issuecomment-738136341
This needs a much more careful review than I've done so far, but I'll share
a few initial impressions:
I prefer the original explanation of Relational Queries on Data Streams in
the Dynamic Tables page. I find it easier to understand.
On the Time Attributes page I like putting event time before processing
time. However, I am wondering about the deletion of the TableSource
sub-sections. I don't like having those sections here -- these are low-level
details that get in the way of understanding -- but is this valuable
information that is being lost?
I mostly like what's going on in the page on joins, but at first I was left
confused by the relationship between versioned tables and temporal joins. I had
to read pretty closely to figure out what's going on; I think there are too
many similar concepts with related names for this to be easy to grasp. I think
we need to think carefully about how to organize the docs so that the
relationships are clear.
I suggest we take the section on Temporal Table Functions out of the page on
versioned tables, along with the section on joins with temporal table functions
in the page on Joins in Continuous Queries, and put those two sections into
their own "THIS PAGE DESCRIBES A LEGACY FEATURE" page by themselves.
We also need to do more than just move things around. Consider this note
concerning the phony temporal table function example `SELECT * FROM
Rates('11:00:00');`:
> Note: Currently, Flink doesn’t support directly querying the temporal
table functions with a constant time attribute parameter. The above example was
used to provide an intuition about what the function Rates(timeAttribute)
returns.
This old note is nonsense, since temporal table functions are a legacy
feature we intend to phase out. But the tone of this note suggests that there
might be further development.
FWIW, these pages have typos and grammar issues, most of which pre-date this
PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
