sjwiesman commented on pull request #14292:
URL: https://github.com/apache/flink/pull/14292#issuecomment-738448892


   Thanks for taking a look @alpinegizmo 
   
   I went back and made a grammar pass on each page (except joins I haven't 
gotten that far yet). 
   
   > I prefer the original explanation of Relational Queries on Data Streams in 
the Dynamic Tables page. I find it easier to understand.
   
   I put the table back and just slightly tweaked the language to try and be 
more approachable
   
   > On the Time Attributes page I like putting event time before processing 
time. However, I am wondering about the deletion of the TableSource 
sub-sections. I don't like having those sections here -- these are low-level 
details that get in the way of understanding -- but is this valuable 
information that is being lost?
   
   The `TableSource` interface is deprecated, that's why I dropped it. 
   
   I also completely rewrote the versioned table description. I think it's much 
better now. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to