wuchong commented on a change in pull request #14316:
URL: https://github.com/apache/flink/pull/14316#discussion_r537334995
##########
File path:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDataDeserializationSchema.java
##########
@@ -101,6 +102,9 @@ public JsonRowDataDeserializationSchema(
public RowData deserialize(byte[] message) throws IOException {
try {
final JsonNode root = objectMapper.readTree(message);
+ if (root instanceof MissingNode) {
Review comment:
I think this is a little hack. This can't handle nested types. Would be
better fix this in
`org.apache.flink.formats.json.JsonToRowDataConverters#wrapIntoNullableConverter`.
And call `JsonToRowDataConverters#createConverter` in the constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]