wuchong commented on a change in pull request #14316:
URL: https://github.com/apache/flink/pull/14316#discussion_r538383411
##########
File path:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonToRowDataConverters.java
##########
@@ -368,7 +369,7 @@ private Object convertField(
private JsonToRowDataConverter wrapIntoNullableConverter(
JsonToRowDataConverter converter) {
return jsonNode -> {
- if (jsonNode == null || jsonNode.isNull()) {
+ if (jsonNode == null || jsonNode.isNull() || jsonNode
instanceof MissingNode) {
Review comment:
Would be better to use `jsonNode.isMissingNode()` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
