[ 
https://issues.apache.org/jira/browse/FLINK-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192897#comment-15192897
 ] 

ASF GitHub Bot commented on FLINK-3610:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1784#issuecomment-196194991
  
    This patch breaks the stable (`@Public`) API. Hence, it should not be 
applied for a 1.x release.
    Is returning a Java `DataStreamSink` a real problem or just an 
inconsistency of the API?


> Scala DataStream#addSink returns Java DataStreamSink
> ----------------------------------------------------
>
>                 Key: FLINK-3610
>                 URL: https://issues.apache.org/jira/browse/FLINK-3610
>             Project: Flink
>          Issue Type: Bug
>          Components: Scala API, Streaming
>    Affects Versions: 1.0.0
>            Reporter: Márton Balassi
>            Assignee: Márton Balassi
>            Priority: Critical
>             Fix For: 1.0.1
>
>
> I have just come across a shortcoming of the streaming Scala API: it 
> completely lacks the Scala implementation of the DataStreamSink and instead 
> the Java version is used. [1]
> I would regard this as a bug that needs a fix for 1.0.1. Unfortunately this 
> is also api-breaking.
> [1] 
> https://github.com/apache/flink/blob/master/flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/DataStream.scala#L928-L929



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to