zhuxiaoshang commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r539039936
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcExecutionOptions.java
##########
@@ -66,12 +76,13 @@ public boolean equals(Object o) {
JdbcExecutionOptions that = (JdbcExecutionOptions) o;
return batchIntervalMs == that.batchIntervalMs &&
batchSize == that.batchSize &&
- maxRetries == that.maxRetries;
+ maxRetries == that.maxRetries &&
+ parallelism == that.parallelism;
Review comment:
Maybe the framework will check whether the parallelism > max parallelism
limit.
Moreover where do you get the 128?IIRC,128 is the limit of max keyGroup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
