zhuxiaoshang commented on a change in pull request #13907:
URL: https://github.com/apache/flink/pull/13907#discussion_r540788857
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/OutputFormatProvider.java
##########
@@ -23,17 +23,29 @@
import org.apache.flink.table.connector.ParallelismProvider;
import org.apache.flink.table.data.RowData;
+import java.util.Optional;
+
/**
* Provider of an {@link OutputFormat} instance as a runtime implementation
for {@link DynamicTableSink}.
*/
@PublicEvolving
public interface OutputFormatProvider extends
DynamicTableSink.SinkRuntimeProvider, ParallelismProvider {
/**
- * Helper method for creating a static provider.
+ * Helper method for creating a static provider with a provided sink
parallelism.
*/
- static OutputFormatProvider of(OutputFormat<RowData> outputFormat) {
- return () -> outputFormat;
+ static OutputFormatProvider of(OutputFormat<RowData> outputFormat,
Integer sinkParallelism) {
Review comment:
According to @fsk119 's suggestion,I removed the old method because it
is never used.
If not i can get it back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
