twalthr commented on a change in pull request #14329:
URL: https://github.com/apache/flink/pull/14329#discussion_r539949533



##########
File path: 
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/DataTypeExtractor.java
##########
@@ -377,6 +397,11 @@ private void checkForCommonErrors(Type type) {
                                        "Usually, this indicates that class 
information is missing or got lost. " +
                                        "Please specify a more concrete class 
or treat it as a RAW type.",
                                Object.class.getName());
+               } else if (INTERNAL_DATA_STRUCTURES.contains(clazz)) {
+                       throw extractionError(
+                               "Cannot extract a data type from a pure 
internal '%s' class. " +

Review comment:
       I improved the message to:
   ```
   Cannot extract a data type from an internal '%s' class without further 
information. " +
                                        "Please use annotations to define the 
full logical type.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to