twalthr commented on a change in pull request #14329:
URL: https://github.com/apache/flink/pull/14329#discussion_r539977002
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/join/LookupJoinTest.scala
##########
@@ -211,24 +212,26 @@ class LookupJoinTest(legacyTableSource: Boolean) extends
TableTestBase with Seri
expectExceptionThrown(
"SELECT * FROM T JOIN LookupTable7 " +
"FOR SYSTEM_TIME AS OF T.proctime AS D ON T.a = D.id AND T.b = D.name
AND T.ts = D.ts",
- "Expected: eval(java.util.concurrent.CompletableFuture, " +
- "java.lang.Integer, org.apache.flink.table.data.StringData, " +
- "org.apache.flink.table.data.TimestampData) \n" +
- "Actual: eval(java.lang.Integer,
org.apache.flink.table.data.StringData, " +
- "java.time.LocalDateTime)",
- classOf[TableException]
+ "Could not find an implementation method 'eval' in class " +
+
"'org.apache.flink.table.planner.plan.utils.InvalidAsyncTableFunctionEvalSignature1'
" +
+ "for function 'default_catalog.default_database.LookupTable7' that
matches the " +
+ "following signature:\n" +
+ "void eval(java.util.concurrent.CompletableFuture,
java.lang.Integer, " +
+ "org.apache.flink.table.data.StringData,
org.apache.flink.table.data.TimestampData)",
Review comment:
No, we fail with internal classes if the function declared `RowData`. I
changed some tests to reflect this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
