tillrohrmann opened a new pull request #14359:
URL: https://github.com/apache/flink/pull/14359


   ## What is the purpose of the change
   
   The AkkaRpcActor failed at sending asynchronous null responses because
   it did not wrap the null value in a Status.Success message for local 
messages.
   For remote messages it ran into a NPE because it did not check the
   SerializedValue.getByteArray(). This commit fixes both problems so that 
Flink's
   RPC service now supports to respond with null values.
   
   ## Verifying this change
   
   Added `RemoteAkkaRpcActorTest` and 
`AkkaRpcActorTest.canRespondWithNullValueLocally` and 
`AkkaRpcActorTest.canRespondWithSynchronousNullValueLocally`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to