zentol commented on a change in pull request #14359:
URL: https://github.com/apache/flink/pull/14359#discussion_r540429208
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcActor.java
##########
@@ -342,10 +342,13 @@ private void sendAsyncResponse(CompletableFuture<?>
asyncResponse, String method
promise.failure(serializedResult.right());
}
} else {
- promise.success(value);
+ promise.success(new
Status.Success(value));
Review comment:
was this silently failing with an exception as well?
##########
File path: flink-core/src/main/java/org/apache/flink/util/SerializedValue.java
##########
@@ -63,6 +66,7 @@ public T deserializeValue(ClassLoader loader) throws
IOException, ClassNotFoundE
*
* @return Serialized data.
*/
+ @Nullable
Review comment:
The BlobWriter and SerializedValueSerializer do not handle the nullable
case appropriately. It seems as if no user of this class so far was properly
handling this case, which makes me wonder whether it a) should never return a
null array or b) not allow null values in the first place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
