leonardBang commented on pull request #14362:
URL: https://github.com/apache/flink/pull/14362#issuecomment-743104445
> Can we maybe change the code instead to handle this case more gracefully?
Thanks @zentol , that's a better way, I rechecked the code and found is
problematic which should use the formatted `this.baseUrl` rather than the
function parameter `baseUrl`:
```
this.baseUrl = baseUrl.endsWith("/") ? baseUrl : baseUrl + "/";
this.defaultUrl = baseUrl + defaultDatabase; => this.defaultUrl =
this.baseUrl + defaultDatabase;
```
And thus the document update is unnecessary and we should change the code
and update the test or add a new test to cover the change.
@kougazhang HDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
