XComp commented on a change in pull request #14359:
URL: https://github.com/apache/flink/pull/14359#discussion_r540905070



##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcActorTest.java
##########
@@ -515,6 +542,29 @@ public void setFoobar(int value) {
 
        // 
------------------------------------------------------------------------
 
+       interface NullRespondingGateway extends DummyRpcGateway {

Review comment:
       Why do we introduce new classes/interfaces here? Can't we just use the 
already existing `DummyRpcGateway`/`NullRespondingEndpoint`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to