zentol commented on a change in pull request #14340:
URL: https://github.com/apache/flink/pull/14340#discussion_r540934164
##########
File path:
flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java
##########
@@ -113,8 +113,8 @@ public void send(DSeries request) throws Exception {
client.newCall(r).enqueue(EmptyCallback.getEmptyCallback());
}
- public static String serialize(Object obj) throws
JsonProcessingException {
- return MAPPER.writeValueAsString(obj);
+ public static String serialize(Object obj, ObjectMapper mapper) throws
JsonProcessingException {
+ return mapper.writeValueAsString(obj);
Review comment:
Yeah I wasn't too happy with it either; it is especially finicky since
every setting the reporter uses for the mapper is ignored by the test :/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
