xiaoHoly commented on pull request #14387: URL: https://github.com/apache/flink/pull/14387#issuecomment-747872906
@wangxlong i had done ConfigOption in JdbcDynamicTableFactory with your advice and Jark'advice ,but i have no idea how to verify this configOption in JdbcDynamicTableFactoryTest.just like other configOption,either check whether the configuration parameters are complete, or check whether the parameters are negative. follow this code ,i dont think we should check complete or negative for max-retry-timeout.WDYT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
