wuchong commented on a change in pull request #14387:
URL: https://github.com/apache/flink/pull/14387#discussion_r545633906
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/options/JdbcOptions.java
##########
@@ -34,7 +34,7 @@
private static final long serialVersionUID = 1L;
- public static final int CONNECTION_CHECK_TIMEOUT_SECONDS = 60;
+ public static int connectionCheckTimeoutSeconds = 60;
Review comment:
This shouldn't be a global variable. This should be a `private final`
variable and please also add this into `hashcode()` and `equals()`.
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactory.java
##########
@@ -284,7 +290,9 @@ private void validateConfigOptions(ReadableConfig config) {
USERNAME,
PASSWORD
});
-
+ checkAllOrNone(config, new ConfigOption[]{
Review comment:
We don't add this check. The `checkAllOrNone` is used for options should
be set or not set togehter, e.g. password + username.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
