[
https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195615#comment-15195615
]
ASF GitHub Bot commented on FLINK-3544:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1741#discussion_r56197090
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/ContaineredTaskManagerParameters.java
---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.clusterframework;
+
+import org.apache.flink.configuration.ConfigConstants;
+import org.apache.flink.configuration.Configuration;
+
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * This class describes the basic parameters for launching a TaskManager
process.
+ */
+public class ContaineredTaskManagerParameters implements
java.io.Serializable {
+
+ private static final long serialVersionUID = -3096987654278064670L;
+
+ /** Total container memory, in bytes */
+ private final long totalContainerMemoryMB;
+
+ /** Heap size to be used for the Java process */
+ private final long taskManagerHeapSizeMB;
+
+ /** Direct memory limit for the Java process */
+ private final long taskManagerDirectMemoryLimitMB;
+
+ /** The number of slots per TaskManager */
+ private final int numSlots;
+
+ /** Environment variables to add to the Java process */
+ private final HashMap<String, String> taskManagerEnv;
+
+
+ public ContaineredTaskManagerParameters(
+ long totalContainerMemoryMB, long taskManagerHeapSizeMB,
+ long taskManagerDirectMemoryLimitMB,
+ int numSlots,
+ HashMap<String, String> taskManagerEnv)
+ {
+ this.totalContainerMemoryMB = totalContainerMemoryMB;
+ this.taskManagerHeapSizeMB = taskManagerHeapSizeMB;
+ this.taskManagerDirectMemoryLimitMB =
taskManagerDirectMemoryLimitMB;
+ this.numSlots = numSlots;
+ this.taskManagerEnv = taskManagerEnv;
+ }
+
+ //
------------------------------------------------------------------------
+
+ public long taskManagerTotalMemoryMB() {
+ return totalContainerMemoryMB;
+ }
+
+ public long taskManagerHeapSizeMB() {
+ return taskManagerHeapSizeMB;
+ }
+
+ public long taskManagerDirectMemoryLimitMB() {
+ return taskManagerDirectMemoryLimitMB;
+ }
+
+ public int numSlots() {
+ return numSlots;
+ }
+
+ public Map<String, String> taskManagerEnv() {
+ return taskManagerEnv;
+ }
+
+
+ //
------------------------------------------------------------------------
+
+ @Override
+ public String toString() {
+ return "TaskManagerParameters {" +
+ "totalContainerMemory=" + totalContainerMemoryMB +
+ ", taskManagerHeapSize=" + taskManagerHeapSizeMB +
+ ", taskManagerDirectMemoryLimit=" +
taskManagerDirectMemoryLimitMB +
+ ", numSlots=" + numSlots +
+ ", taskManagerEnv=" + taskManagerEnv +
+ '}';
+ }
+
+ //
------------------------------------------------------------------------
+ // Factory
+ //
------------------------------------------------------------------------
+
+ /**
+ * Computes the parameters to be used to start a TaskManager Java
process.
+ *
+ * @param config The Flink configuration.
+ * @param containerMemoryMB The size of the complete container, in
megabytes.
+ * @return The parameters to start the TaskManager processes with.
+ */
+ public static ContaineredTaskManagerParameters create(
+ Configuration config, long containerMemoryMB, int numSlots)
+ {
+ // (1) compute how much memory we subtract from the total
memory, to get the Java memory
+
+ final float memoryCutoffRatio = config.getFloat(
+ ConfigConstants.CONTAINERED_HEAP_CUTOFF_RATIO,
+ ConfigConstants.DEFAULT_YARN_HEAP_CUTOFF_RATIO);
+
+ final int minCutoff = config.getInteger(
+ ConfigConstants.CONTAINERED_HEAP_CUTOFF_MIN,
+ ConfigConstants.DEFAULT_YARN_HEAP_CUTOFF);
+
+ if (memoryCutoffRatio > 1 || memoryCutoffRatio < 0) {
--- End diff --
Do we allow a `memoryCutoffRatio` of `1`?
> ResourceManager runtime components
> ----------------------------------
>
> Key: FLINK-3544
> URL: https://issues.apache.org/jira/browse/FLINK-3544
> Project: Flink
> Issue Type: Sub-task
> Components: ResourceManager
> Affects Versions: 1.1.0
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
