wangyang0918 edited a comment on pull request #49:
URL: https://github.com/apache/flink-docker/pull/49#issuecomment-749300920
@rogaha I assume you mean to completely remove the `run` command and make
the preparatory works(e.g. copy plugins, set environment variables, etc.)
directly work for all normal commands.
@tianon `docker run flink:xxx run flink run -h` is just printing the help
message. It does not have some concrete use cases.
The following full example is to start a native K8s session cluster with
minimum parameters. I have verified it could work.
```
docker run -v /path/of/kubeconfig:/opt/flink/.kube/config
registry.cn-beijing.aliyuncs.com/streamcompute/flink:1.12.0-run run bash -c
'java -classpath $FLINK_CLASSPATH
-Dlog4j.configurationFile=file:/opt/flink/conf/log4j-console.properties
org.apache.flink.kubernetes.entrypoint.KubernetesSessionClusterEntrypoint
-Dkubernetes.cluster-id=k8s-native-session-1'
```
All in all, I think the main concern of you both is how to expose the common
command functionality. Instead of introducing a `run` command, I could change
it to directly work on all normal commands. The we could get the following
examples. Do them make sense?
```
docker run flink:1.12 ls /tmp
docker run flink:1.12 bash -c 'java -classpath $FLINK_CLASSPATH
-Dlog4j.configurationFile=file:/opt/flink/conf/log4j-console.properties
org.apache.flink.kubernetes.entrypoint.KubernetesSessionClusterEntrypoint
-Dkubernetes.cluster-id=k8s-native-session-1'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
