HuangZhenQiu commented on pull request #8952: URL: https://github.com/apache/flink/pull/8952#issuecomment-750402556
@xintongsong For your last three comments, I updated accordingly. The last concern from my side is that the ratePerMinute in Meter is kind of different from the real currentFailureRate. For example, if there are 3 failures in the first 1 second, the rate per minute will return 3 * 60 = 180, but the value we use to compare with the threshold is the value seen since the last one minute which is still 3. Thus, the alert threshold will be different from the maximum failure rate specified in config. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
