echauchot commented on pull request #14510: URL: https://github.com/apache/flink/pull/14510#issuecomment-752006927
@zentol thanks for the quick comment. I totally agree with what you said, I was not happy with this solution either. I used this PR as a discussion environment. This poor design is a consequence of my desire to introduce a default filter for reporters. But, yes, it is better to introduce the default filter in FrontMetricGroup when the provided one is null. I just did not do so because I was afraid that it was not the only place a filter was needed. If you think it is needed only there, fair enough. I'll drop this code and restart from master. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
