echauchot commented on pull request #14510:
URL: https://github.com/apache/flink/pull/14510#issuecomment-752907676


   @zentol I remade the work from scratch using _FrontMetricGroup_ for 
filter/delimiter injection:
   
   - I made sure that the configured delimiter is used in filtering when 
creating the metrics identifier
   - I added a _MetricsGroup#getAllVariables()_ version that takes a 
_CharacterFilter_. And made sure that the configured delimiter is used in 
filtering variable names and values.
   - I added the related tests in _AbstractMetricGroupTest_.
   
   PTAL.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to