wuchong commented on a change in pull request #14534:
URL: https://github.com/apache/flink/pull/14534#discussion_r551128333
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogGenericMetadataTest.java
##########
@@ -288,6 +293,45 @@ public void testTableSchemaCompatibility() throws
Exception {
}
}
+ @Test
+ public void testFunctionCompatibility() throws Exception {
+ catalog.createDatabase(db1, createDb(), false);
+ catalog.createFunction(path1, new
CatalogFunctionImpl("flink:class.name"), false);
Review comment:
IIUC, the `flink:` prefix is added by HiveCatalog in
`instantiateHiveFunction`. Therefore, the class name in `CatalogFunction`
shouldn't contain `flink:` prefix, because it is passed by the Flink framework,
it will never pass a "flink:class.name" to a catalog.
However, it seems that we can't get the metastore client here for writing a
specific function into it... Maybe we can add a comment above this line to
explain why we use a `flink:` prefixed class name here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
