lirui-apache commented on a change in pull request #14534:
URL: https://github.com/apache/flink/pull/14534#discussion_r551131655



##########
File path: 
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogGenericMetadataTest.java
##########
@@ -288,6 +293,45 @@ public void testTableSchemaCompatibility() throws 
Exception {
         }
     }
 
+    @Test
+    public void testFunctionCompatibility() throws Exception {
+        catalog.createDatabase(db1, createDb(), false);
+        catalog.createFunction(path1, new 
CatalogFunctionImpl("flink:class.name"), false);

Review comment:
       I see your point. Actually we can directly call metastore client to 
create the function and I agree that'll make the test easier to understand.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to