aljoscha commented on a change in pull request #14312:
URL: https://github.com/apache/flink/pull/14312#discussion_r551353423
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputProcessorFactory.java
##########
@@ -90,24 +94,51 @@
InputSelectable inputSelectable =
streamOperator instanceof InputSelectable ? (InputSelectable)
streamOperator : null;
- if (streamConfig.shouldSortInputs()) {
+
+ // this is a bit verbose because we're manually handling input1 and
input2
+ // TODO: extract method
+ StreamConfig.InputConfig[] inputConfigs =
streamConfig.getInputs(userClassloader);
+ boolean input1IsSorted = requiresSorting(inputConfigs[0]);
+ boolean input2IsSorted = requiresSorting(inputConfigs[1]);
+
+ if (input1IsSorted || input2IsSorted) {
+ // as soon as one input requires sorting we need to treat all
inputs differently, to
+ // make sure that pass-through inputs have precedence
if (inputSelectable != null) {
throw new IllegalStateException(
"The InputSelectable interface is not supported with
sorting inputs");
}
- @SuppressWarnings("unchecked")
+ List<StreamTaskInput<?>> sortedTaskInputs = new ArrayList<>();
+ List<StreamTaskInput<?>> passThroughTaskInputs = new ArrayList<>();
+ int input1Index = 0;
Review comment:
fixing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
