aljoscha commented on a change in pull request #14312:
URL: https://github.com/apache/flink/pull/14312#discussion_r551357346



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/translators/TwoInputTransformationTranslator.java
##########
@@ -46,7 +47,11 @@
                 transformation.getStateKeySelector1() != null
                         && transformation.getStateKeySelector2() != null;
         if (isKeyed) {

Review comment:
       I think we have to yes. I shied away from it here because I would have 
to add a test that uses the low-level API because right now it's not possible 
for users to create such transforms.
   
   Could you maybe whip together a test based on the existing test code you 
already had? We add it here and I change it to correctly forward the 
requirements?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to