zentol commented on a change in pull request #14510:
URL: https://github.com/apache/flink/pull/14510#discussion_r551249823



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
##########
@@ -107,6 +108,8 @@
     /** Flag indicating whether this group has been closed. */
     private volatile boolean closed;
 
+    @VisibleForTesting public static final char DEFAULT_REPLACEMENT = '_';

Review comment:
       ```suggestion
       @VisibleForTesting
       public static final char DEFAULT_REPLACEMENT = '_';
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to