zentol commented on a change in pull request #14510:
URL: https://github.com/apache/flink/pull/14510#discussion_r554996687
##########
File path:
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/MetricGroup.java
##########
@@ -186,6 +186,15 @@
*/
Map<String, String> getAllVariables();
+ /**
+ * Returns a map of all variables and their associated value, for example
{@code
+ * {"<host>"="host-7", "<tm_id>"="taskmanager-2"}}.
+ *
+ * @param filter character filter which is applied to the variables and
values if not null.
+ * @return map of all variables and their associated value
+ */
+ Map<String, String> getAllVariables(CharacterFilter filter);
Review comment:
I think we will need it in the `AbstractMetricGroup`.
Ideally no class works directly against the `FrontMetricGroup`; this
currently only happens for some reporters because we do not find the time to
properly move `getLogicalScope()` into the `MetricGroup` interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
