tillrohrmann commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r553957897



##########
File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManagerDriver.java
##########
@@ -124,6 +125,8 @@ public YarnResourceManagerDriver(
         super(flinkConfig, 
GlobalConfiguration.loadConfiguration(configuration.getCurrentDir()));
 
         this.yarnConfig = new YarnConfiguration();
+        
yarnConfig.addResource(HadoopUtils.getHadoopConfiguration(flinkConfig));
+        yarnConfig.addResource(Utils.getYarnConfiguration(flinkConfig));

Review comment:
       I think we should still put this logic in the `Utils` class and then 
reuse it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to