tillrohrmann commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r555111876
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManagerDriver.java
##########
@@ -124,6 +125,8 @@ public YarnResourceManagerDriver(
super(flinkConfig,
GlobalConfiguration.loadConfiguration(configuration.getCurrentDir()));
this.yarnConfig = new YarnConfiguration();
+
yarnConfig.addResource(HadoopUtils.getHadoopConfiguration(flinkConfig));
+ yarnConfig.addResource(Utils.getYarnConfiguration(flinkConfig));
Review comment:
I would be in favour of only having a single method at them moment. Once
we need to load a `YarnConfiguration` w/o the `HadoopConfiguration`, we can
split the method. But until then, I would like to keep it simple.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
