rkhachatryan commented on a change in pull request #14567:
URL: https://github.com/apache/flink/pull/14567#discussion_r555045765
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -26,7 +26,14 @@
import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
import org.apache.flink.streaming.api.graph.StreamConfig;
import org.apache.flink.streaming.api.operators.MailboxExecutor;
-import org.apache.flink.streaming.runtime.tasks.SubtaskCheckpointCoordinator;
+import
org.apache.flink.streaming.runtime.tasks.checkpointing.AlignedController;
+import
org.apache.flink.streaming.runtime.tasks.checkpointing.AlternatingController;
+import
org.apache.flink.streaming.runtime.tasks.checkpointing.CheckpointBarrierBehaviourController;
Review comment:
> Those classes have very little in common with task package
IMO they do have because they run inside (sub)task. In contrast to
`CheckpointCoordinator` which runs in JM (and which is in
`org.apache.flink.runtime.checkpoint`).
> Why not to move all of it to
org.apache.flink.streaming.runtime.io.checkpointing?
I think checkpointing has nothing to with IO except in very general case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
