zentol commented on a change in pull request #14618:
URL: https://github.com/apache/flink/pull/14618#discussion_r555768917
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/job/overview/backpressure/job-overview-drawer-backpressure.component.ts
##########
@@ -41,6 +41,15 @@ export class JobOverviewDrawerBackpressureComponent
implements OnInit, OnDestroy
return node.subtask;
}
+ prettyPrint(value: number): string {
+ if (isNaN(value)) {
+ return "N/A"
+ }
+ else {
+ return Math.round(value * 100) + "%";
Review comment:
I was just reminded of FLINK-20424 where rounding to 100% could be
misleading.
For backpressure/idling I think the distinction between 99.6% and 100% could
be important (doing _something_ vs doing _nothing_). But that's just me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
