zentol commented on a change in pull request #14618:
URL: https://github.com/apache/flink/pull/14618#discussion_r555810906
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/job/overview/backpressure/job-overview-drawer-backpressure.component.ts
##########
@@ -41,6 +41,15 @@ export class JobOverviewDrawerBackpressureComponent
implements OnInit, OnDestroy
return node.subtask;
}
+ prettyPrint(value: number): string {
+ if (isNaN(value)) {
+ return "N/A"
+ }
+ else {
+ return Math.round(value * 100) + "%";
Review comment:
I don't mind rounding, that is all fine. The key thing is whether to
round up or down ;) If we're making a conscious decision to round to the
nearest integer, then that's fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
