XComp commented on a change in pull request #14593:
URL: https://github.com/apache/flink/pull/14593#discussion_r555774052
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java
##########
@@ -1284,10 +1270,12 @@ private void disposeAllOperatorCoordinators() {
return coordinatorMap.values();
}
- private Map<OperatorID, OperatorCoordinatorHolder> createCoordinatorMap() {
+ private Map<OperatorID, OperatorCoordinatorHolder> createCoordinatorMap(
+ ComponentMainThreadExecutor mainThreadExecutor) {
Map<OperatorID, OperatorCoordinatorHolder> coordinatorMap = new
HashMap<>();
for (ExecutionJobVertex vertex :
executionGraph.getAllVertices().values()) {
for (OperatorCoordinatorHolder holder :
vertex.getOperatorCoordinators()) {
+ holder.lazyInitialize(this, mainThreadExecutor);
Review comment:
Never mind: I didn't see that this method is actually instantiating
`coordinatorMap` 😇
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
