becketqin commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r557809080
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceITCase.java
##########
@@ -82,6 +82,57 @@ public void testBasicRead() throws Exception {
executeAndVerify(env, stream);
}
+ @Test
+ public void testParitionDiscoverySetting() throws Exception {
Review comment:
It seems better to put this test into a new `KafkaSourceBuilderTest`
class and separate it to a few methods testing one case each.
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSource.java
##########
@@ -108,6 +108,15 @@
return new KafkaSourceBuilder<>();
}
+ /**
+ * Returns the props for the Kafka Source.
+ *
+ * @return props for the Kafka Source.
+ */
+ public Properties getProps() {
Review comment:
Should this method be added to `KafkaSourceBuilder` instead of in
`KafkaSource`? And this method probably should be package private.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
