becketqin commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r562412668
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -396,6 +396,11 @@
props);
}
+ /** setParitionDiscoverySetting . */
Review comment:
This method seems quite confusing. I would suggest the following:
1. Make `parseAndSetRequiredProperties()` package private and annotate it as
`VisibleForTesting`.
2. Add a package private `getProps()` method to the `KafkaSourceBuilder` and
annotate it as `VisibleForTesting`.
The unit test can just use the above two methods without exposing them to
the end users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
